maxPagesToFetch bug#155
Open
cmacdonald wants to merge 1 commit intoyasserg:masterfrom
Open
Conversation
Contributor
|
In the changes I don't see any use to the maxPagesToSchedule |
Author
|
To be clear, I didn't name any code called maxPagesToSchedule. However, maxPagesToSchedule could be added in schedule() and scheduleAll(). But I agree with your premise that such semantics (i.e. the status quo) is not actually useful. |
pgalbraith
added a commit
to pgalbraith/crawler4j
that referenced
this pull request
Nov 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, this is a bit more subtle.
The config option is maxPagesToFetch. However, as currently implemented its semantics would be better described as maxPagesToSchedule.
Consider the following use case:
This fails because once the queue has 20 pages in it, no more pages are added to it.
This patch fixes the semantic of the config option so that pages are added to the queue, but queue consumption stops once maxPagesToFetch has been exceeded. This is also useful if you are inserting pages into the queue with higher priorities.