Extracted interfaces from Parser and PageFetcher #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted interfaces from Parser and PageFetcher in order to make it easier to create totally custom classes
Made a silly change in an error in javadoc in order to make a commit and pass the merge checks again, now that the bug in java8 checks is fixed in repo
There was an http fetch error on Java11 test. Commit to pass the test again
Author
|
Strange test error: Could not GET 'https://repo.maven.apache.org/maven2/com/github/tomakehurst/wiremock/2.21.0/wiremock-2.21.0.pom'. Received status code 403 from server: Forbidden |
This modification would allow to use a database other than sleepycat easilly.
Allows to use any implementation for the DocIDServer, not only sleepycat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted interfaces from Parser and PageFetcher in order to make it easier to create totally custom classes.
I'd rename the classes so interfaces would be Parser and PageFetcher and concrete clases SimpleParser and SimplePageFetcher or something like that, but that would break compatibility in projects that instantiate their own, so I decided not to touch it and let maintainer decide, maybe deprecating old names and removing them later, or just leave it as it is