Configurable database names #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to configure the database names from the CrawlControler constructor.
Contributor
|
This pull request makes sense to me, I think it should be merged Please note that I didn't look deeply into the code, but this feature is a good one |
Modified to make InProcessPagesDB configurable.
Author
|
Thanks for your note. Just for the record, the only changes performed are changing constants which are used as arguments for sleepycat are now constructor arguments for the calling classes. I've added those constructors maintaining old ones for retro-compatibility. InProcessPagesDB was not configurable since I didn't need it, but now that someone showed interest for this I've just added it to the code I was thinking about including it into CrawlConfig variable, however, I thought it would be harded to get merged (more code to review by maintainer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to configure the database names from the CrawlControler constructor.
It allowed me to create multiple CrawlerControllers on the same working directory without having the URLs mixed between them.
Substituting #420 because I broke the branch