Timeoutable regular expressions in RobotstxtServer #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimeoutablePathRule adds support to timeout Regexp that run for too long. You can configure them to consider that a timeout means a match, or a not match. Personally I'd throw RegexpTimeoutException, but it may break some foreign subclasses, so I decided to stick to return false. The static version, matchesRobotsPattern throws RegexpTimeoutException if configured to fail on timeout since it will not break any existing code.
UserAgentDirectives creates TimeoutablePathRule if configured to do so
Timeout for regexp is now configurable in RobotstxtConfig. RobotstxtParser passes the RobotstxtConfig arguments to use TimeoutablePathRule if necesary. Style fix in TimeoutablePathRule
dgoiko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425 by creating Matchers that throw RuntimeExceptions on timeout and a TimeoutablePathRule that extends PathRule that uses them.
The default behaviour of the system is not to use them, however, it can be enabled via RobotstxtConfig.
NOTE: The code for the timeoutable Matches is based on this stackoverflow answer and it decreases performance of regexp. The ideal thing should be to include a native efficient and timeoutable regex library, but this is a valid workaround