Allow to differentiate between queue sizes in Frontier#60
Open
EgbertW wants to merge 1 commit intoyasserg:masterfrom
Open
Allow to differentiate between queue sizes in Frontier#60EgbertW wants to merge 1 commit intoyasserg:masterfrom
EgbertW wants to merge 1 commit intoyasserg:masterfrom
Conversation
IN_PROGRESS_QUEUE or WORK_QUEUE | IN_PROGRESS_QUEUE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I recently discovered that you moved from google code to Github. I've been using and modifying crawlerj4 for a while now and now I'm able to submit pull requests to allow you to merge them. I rebased all my (relevant) patches on the new master, so they should be easy to merge. I hope you consider some or all of them useful.
Description of this patch:
Allow to differentiate between queue sizes in Frontier: WORK_QUEUE, IN_PROGRESS_QUEUE or WORK_QUEUE | IN_PROGRESS_QUEUE. I was in eed of a reliable method to get the combined size of the work queue and the inProgressQueue, without the risk of either of them changing in between the requests. Hence this method.