Better management of proxies#80
Open
Bouki wants to merge 3 commits intoyasserg:masterfrom
Bouki:master
Open
Conversation
Allow using one proxy per fetched page
|
How about this commit? Is it accepted? |
|
You could just use a local proxy server to handle proxy redirects. That way you can easily achieve proxy rotation without touching crawler4j's code. Take a look at: https://github.com/adamfisk/LittleProxy and |
Contributor
|
A modern crawler should have a proxy rotation feature. I would gladly accept PRs about this as long they comes with some tests around them. @Bouki, please add some some tests. Another option is to use dedicated external proxy like @helfsoft suggested. |
Author
|
Sorry I can't add tests because this commit is 2 years old it certainly needs an update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using one proxy per fetched page instead of one proxy per seed