Support for new libzypp callbacks #192
Merged
+121
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
imobachgs
force-pushed
the
new_libzypp_callbacks
branch
from
9ccbf71 to
f14f0ae
Compare
mvidner
reviewed
Jul 1, 2025
| YCPValue CallbackDonePackage (const YCPValue& /*nil*/ args); | ||
|
|
||
| /* TYPEINFO: void(void(map<string,any>)) */ | ||
| YCPValue CallbackStartInstallResolvableSA( const YCPValue& args ); |
Member
There was a problem hiding this comment.
The meaning of the "SA" suffix is a mystery :(
mvidner
requested changes
Jul 1, 2025
Member
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
Docs: missing, even though we have tooling for it. I will add it.
Code: looks good
Dependencies: surprisingly to me, the Zypp API is old so the BuildRequires are already fine
| YCPValue PkgFunctions::CallbackStartInstallResolvableSA( const YCPValue& args ) { | ||
| return SET_YCP_CB( CB_StartInstallResolvableSA, args ); | ||
| } | ||
| YCPValue PkgFunctions::CallbackProgressInstallResolvableSA( const YCPValue& args ) { |
Member
There was a problem hiding this comment.
The additional integer argument to the callback is precentage from 0 to 100??
mvidner
approved these changes
Jul 1, 2025
Member
mvidner
left a comment
mvidner
left a comment
There was a problem hiding this comment.
With my docs improvement I consider it good enough :-)
imobachgs
approved these changes
Jul 1, 2025
Member
|
BTW #168 (from 2021, unfinished) was a previous attempt of implementing this kind of "single transaction" Zypp callbacks. |
|
✅ Autosubmission job #15999626083 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
TODO