Skip to content

Remove system forwarding optin#72

Merged
ngetahun merged 4 commits into
masterfrom
remove_system_forwarding_optin
Mar 16, 2026
Merged

Remove system forwarding optin#72
ngetahun merged 4 commits into
masterfrom
remove_system_forwarding_optin

Conversation

@ngetahun

@ngetahun ngetahun commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

This PR removes the check box for system scc sync configuration.

Testing

  • bundle exec rake run, you should not see a checkbox when adding scc credenetial

Screenshots

image

@coveralls

coveralls commented Feb 18, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23151376290

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 98.558%

Totals Coverage Status
Change from base Build 19816236814: -0.002%
Covered Lines: 1640
Relevant Lines: 1664

💛 - Coveralls

Comment thread src/lib/rmt/wizard_scc_page.rb Outdated
Comment thread src/lib/rmt/wizard_scc_page.rb Outdated
@ngetahun ngetahun force-pushed the remove_system_forwarding_optin branch from 4c87aee to d454e47 Compare February 26, 2026 10:05

@lcaparroz lcaparroz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it both in the graphical interface and on a terminal:

  • Graphical interface:

    Image
  • Terminal:

    Image

Worked as expected :)

@ngetahun ngetahun merged commit 5da57e4 into master Mar 16, 2026
8 checks passed
@ngetahun ngetahun deleted the remove_system_forwarding_optin branch March 16, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants