fix: ts-migrating directive not working on last function parameter #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahalperin
force-pushed
the
bh/fix-directive-not-working-in-function-argument-2
branch
from
5e15104 to
1c441fa
Compare
ycmjason
force-pushed
the
bh/fix-directive-not-working-in-function-argument-2
branch
2 times, most recently
from
874b083 to
feb7d0a
Compare
Owner
|
Thanks for reporting the issue and fixing it! Appreciate this so much! I have added a test to cover this too. Will merge and release soon! |
Owner
|
released in 1.4.0 |
Contributor
Author
Of course! Thanks for reviewing and merging it so quickly. At my job we've been looking to move to strict mode for a while now but haven't found a solution that works well for us. This does exactly what we want and we're excited to use it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8