Skip to content

Conversation

@jkuradobery
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new filesystem snapshot dataplane schema and storage layer for the disk manager. It introduces a YDB-backed storage implementation for managing filesystem snapshot metadata, including creation, deletion, locking, and lifecycle management operations. The implementation follows patterns established in the existing snapshot storage module.

Key Changes

  • Introduces FilesystemSnapshotMeta storage interface with YDB implementation supporting snapshot CRUD operations and locking mechanisms
  • Adds database schema with tables for filesystem snapshots, node metadata, and deletion tracking
  • Provides comprehensive test coverage for all storage operations including idempotency, locking, and deletion workflows

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
cloud/disk_manager/internal/pkg/dataplane/ya.make Adds filesystem_snapshot module to build configuration
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/ya.make Defines build structure for filesystem_snapshot module
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/ya.make Configures library with source files and test dependencies
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/tests/ya.make Sets up test environment with YDB recipe and resource requirements
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/storage.go Defines Storage interface and FilesystemSnapshotMeta structure
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/storage_ydb.go Implements YDB storage backend with transaction handling and query operations
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/storage_ydb_test.go Provides comprehensive test coverage for all storage operations
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/common.go Defines internal state structures and snapshot status enumeration
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/schema/ya.make Build configuration for schema package
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/schema/schema.go Implements database schema creation and deletion with multiple tables
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/protos/ya.make Build configuration for protobuf definitions
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/protos/types.proto Defines DeletingFilesystemSnapshotKey message for deletion tracking
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/mocks/ya.make Build configuration for mock implementations
cloud/disk_manager/internal/pkg/dataplane/filesystem_snapshot/storage/mocks/storage_mock.go Provides StorageMock for testing using testify/mock

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ce7f0bd.

TESTS PASSED ERRORS FAILED FAILED BUILD SKIPPED MUTED?
9684 9683 0 0 0 1 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants