[NBS] Pull scheme for non replicated disks #4792
Conversation
|
Hi! Thank you for contributing! |
komarevtsev-d
added
blockstore
github-actions
bot
removed
the
ok-to-test
PeshkovMikhail
changed the title
PeshkovMikhail
changed the title
komarevtsev-d
left a comment
komarevtsev-d
left a comment
There was a problem hiding this comment.
LGTM; Смотрел на эти изменения в другом ПРе
|
|
||
| auto* msg = ev->Get(); | ||
|
|
||
| if (msg->SeqNo < StatisticSeqNo) { |
There was a problem hiding this comment.
В каком случае могут перепутаться запросы?
There was a problem hiding this comment.
Сейчас это больше перестраховка.
Если ответа на запрос статистики не поступило за 15 секунд, а при перепосылке запроса поступил какой-то ответ, то мы хотим быть уверены, что это новый, а не какой-то из прошлого
There was a problem hiding this comment.
А точно нужна эта перестраховка? Сообщения локальные, в одном процессе.
There was a problem hiding this comment.
Ну страхуемся от багов короче, скорее так. Можно и убрать наверно.
| void Bootstrap(const NActors::TActorContext& ctx); | ||
|
|
||
| private: | ||
| void SendStatistics(const NActors::TActorContext& ctx); |
| release_devices_actor.cpp | ||
| shadow_disk_actor.cpp | ||
| volume_as_partition_actor.cpp | ||
| partition_statistics_collector_actor.cpp |
There was a problem hiding this comment.
partition_statistics_collector_actor.cpp уже есть в ya.make
| std::make_unique<TEvVolume::TEvDiskRegistryBasedPartitionCounters>( | ||
| MakeIntrusive<TCallContext>(), | ||
| std::move(diskCounters), | ||
| PartConfig->GetName(), | ||
| networkBytes, | ||
| cpuUsage); |
There was a problem hiding this comment.
М.б. заиспользовать TPartNonreplCountersData в TDiskRegistryBasedPartitionCounters:
struct TDiskRegistryBasedPartitionCounters
{
TString DiskId;
TPartNonreplCountersData CountersData;
TDiskRegistryBasedPartitionCounters(
TString diskId,
TPartNonreplCountersData countersData)
: DiskId(std::move(diskId))
, CountersData(std::move(countersData))
{}
};?
Тогда не надо будет каждый раз конструировать TPartNonreplCountersData:
auto request =
std::make_unique<TEvVolume::TEvDiskRegistryBasedPartitionCounters>(
MakeIntrusive<TCallContext>(),
DiskId,
ExtractPartCounters(ctx));
...
UpdateCounters(ctx, ev->Sender, std::move(msg->CountersData));
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| struct TPartNonreplCountersData |
There was a problem hiding this comment.
М.б. в disk_counters.h положить?
| TPartitionDiskCountersPtr DiskCounters; | ||
| ui64 NetworkBytes; | ||
| TDuration CpuUsage; |
There was a problem hiding this comment.
TPartNonreplCountersData CountersData;
PeshkovMikhail
force-pushed
the
new-pull-scheme-nonrepl
branch
from
3bab0f0 to
0bfe8a8
Compare
komarevtsev-d
left a comment
komarevtsev-d
left a comment
There was a problem hiding this comment.
Надо выпилить seqNo отовсюду
| size_t MultiAgentWriteRoundRobinSeed = 0; | ||
|
|
||
| TRequestInfoPtr StatisticRequestInfo; | ||
| ui64 StatisticSeqNo = 0; |
There was a problem hiding this comment.
Надо из всех акторов выпилить это поле
|
|
||
| struct TDiskRegistryBasedPartCountersCombined | ||
| { | ||
| const ui64 SeqNo; |
4 participants
Issue #3154
This is the second step in the transition from a push scheme to a pull scheme for collecting statistics of partitions.
The first part was about YDB-based disks: #3803
This PR is about DR-based disks.
Added
TDiskRegistryBasedPartitionStatisticsCollectorActor, which is used in DR-based partitions that own multiple other partitions (e.g., mirror partition, migration partition). This actor manages the process of collecting statistics from its children.With the
UsePullSchemeForVolumeStatisticssetting enabled, statistics should be collected faster due to the absence of delays in sending them from the partition.