[Blockstore] Use templatable Volume Monitoting dashboard URL on the monitoring pages #4826
+151
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
akilvein
commented
Dec 11, 2025
akilvein
commented
- Add config settings for grafana dashboards
- GetMonitoringVolumeUrl returns link to grafana volume dashboard if grafana url is configured
Contributor
|
Hi! Thank you for contributing! |
debnatkh
reviewed
Dec 15, 2025
| optional string MonitoringUrlTemplate = 10; | ||
|
|
||
| // monitoring datasource pid for this ClusterName | ||
| optional string MonitoringDataSourcePid = 11; |
Collaborator
There was a problem hiding this comment.
not necessary in opensource. we can safely use MonitoringProject
| << data.MonitoringClusterName << "&p.volume=" << diskId; | ||
|
|
||
| if (data.MonitoringUrlTemplate.empty()) { | ||
| // backward compatibility |
Collaborator
There was a problem hiding this comment.
better to keep the old intact
|
|
||
| auto substitute = [&result](TStringBuf placeholder, TStringBuf value) | ||
| { | ||
| SubstGlobal(result, placeholder, value); |
| return out; | ||
| } | ||
|
|
||
| TString GetUrlFromTemplate( |
Collaborator
There was a problem hiding this comment.
better to move to anonymous namespace
debnatkh
reviewed
Dec 17, 2025
akilvein
changed the title
debnatkh
added
ok-to-test
github-actions
bot
removed
the
ok-to-test
Contributor
akilvein
force-pushed
the
users/akilvein/volume-monitoring-url
branch
from
685f1b3 to
aa3b9bc
Compare
debnatkh
reviewed
Dec 18, 2025
Contributor
Contributor
debnatkh
previously approved these changes
Dec 19, 2025
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 125d148.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 125d148.
🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 125d148.
|
Contributor
Contributor
debnatkh
previously approved these changes
Dec 22, 2025
debnatkh
changed the title
agalibin
reviewed
Dec 24, 2025
|
|
||
| if (data.MonitoringUrlTemplate.empty()) { | ||
| return TStringBuilder() | ||
| << data.MonitoringUrl << "/projects/" << data.MonitoringProject |
Collaborator
There was a problem hiding this comment.
тут беда с форматированием, до этого было правильное
agalibin
reviewed
Dec 24, 2025
| << data.MonitoringClusterName << "&p.volume=" << diskId; | ||
| } | ||
|
|
||
| return GetUrlFromTemplate( |
Collaborator
There was a problem hiding this comment.
Тут тоже. В целом clang прогнать на новый код и не надо об этом думать.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.