Skip to content

issue-3781: TFileRingBuffer - operations should return verbose errors #6866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e673 wants to merge 5 commits into from
Open

issue-3781: TFileRingBuffer - operations should return verbose errors #6866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
926ae0c
issue-3781: TFileRingBuffer - verbose API
Aug 21, 2026
a897fdb
Make IsCorrupted and SetCorrupted thread-safe
Aug 21, 2026
42a55f0
AI review fix: Visit and SetTag
Aug 21, 2026
92414f2
AI review: detect corruption in Free()/PopFront()
Aug 21, 2026
7fa4981
AI review: move code to a separate file, more asserts
Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions cloud/filestore/libs/vfs_fuse/handle_ops_queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ THandleOpsQueue::EResult THandleOpsQueue::AddCreateRequest(
return THandleOpsQueue::EResult::SerializationError;
}

if (!RequestsToProcess.PushBack(result)) {
auto pushPackResult = RequestsToProcess.PushBack(result);
if (HasError(pushPackResult) || !pushPackResult.GetResult()) {
Stats->IncrementOverflowErrorCount();
return THandleOpsQueue::EResult::QueueOverflow;
}
Expand All @@ -60,7 +61,8 @@ THandleOpsQueue::EResult THandleOpsQueue::AddDestroyRequest(
return THandleOpsQueue::EResult::SerializationError;
}

if (!RequestsToProcess.PushBack(result)) {
auto pushPackResult = RequestsToProcess.PushBack(result);
if (HasError(pushPackResult) || !pushPackResult.GetResult()) {
Stats->IncrementOverflowErrorCount();
return THandleOpsQueue::EResult::QueueOverflow;
}
Expand All @@ -71,7 +73,13 @@ THandleOpsQueue::EResult THandleOpsQueue::AddDestroyRequest(

std::optional<NProto::TQueueEntry> THandleOpsQueue::Front()
{
const auto req = RequestsToProcess.Front();
const auto frontResult = RequestsToProcess.Front();
if (HasError(frontResult)) {
Stats->IncrementParseErrorCount();
return std::nullopt;
}

const auto req = frontResult.GetResult();

NProto::TQueueEntry entry;
if (!entry.ParseFromArray(req.data(), req.size())) {
Expand Down
12 changes: 8 additions & 4 deletions cloud/filestore/libs/vfs_fuse/write_back_cache/persistent_storage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,19 @@ class TFileRingBufferStorage: public IPersistentStorage

void Commit() override
{
bool success = Storage.Commit();
Y_ENSURE(success, "Failed to commit allocation");
auto res = Storage.Commit();
Y_ENSURE(
!HasError(res),
"Failed to commit allocation: " << FormatError(res));
Comment on lines +103 to +105

@SvartMetal SvartMetal Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of exceptions usage?

@e673 e673 Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, But this is unrelated to this PR and will be done in the next one
https://github.com/ydb-platform/nbs/pull/6867/changes#diff-4fd6698976acda0e55fdcf9397499b66e0c11ccd7e4517758b7d2296129c5ff6R102

SetCounters();
}

void Free(const void* ptr) override
{
bool success = Storage.Free(ptr);
Y_ENSURE(success, "Failed to free pointer " << ptr);
auto res = Storage.Free(ptr);
Y_ENSURE(
!HasError(res),
"Failed to free pointer " << ptr << ": " << FormatError(res));
SetCounters();
}

Expand Down
Loading
Loading