feat: supported attach hint by KirillKurdyukov · Pull Request #833 · ydb-platform/ydb-python-sdk

KirillKurdyukov · 2026-06-05T09:24:57Z

No description provided.

codecov-commenter · 2026-06-11T09:14:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.32%. Comparing base (dc20074) to head (71b827d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   81.30%   81.32%   +0.02%     
==========================================
  Files          94       94              
  Lines       12162    12189      +27     
  Branches     1194     1202       +8     
==========================================
+ Hits         9888     9913      +25     
- Misses       1809     1810       +1     
- Partials      465      466       +1

Flag	Coverage Δ
integration	`79.15% <100.00%> (+0.06%)`	⬆️
unit	`47.21% <20.68%> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
ydb/aio/pool.py	`75.21% <100.00%> (+0.64%)`	⬆️
ydb/aio/query/session.py	`88.60% <ø> (-0.15%)`	⬇️
ydb/pool.py	`83.88% <100.00%> (+0.49%)`	⬆️
ydb/query/session.py	`91.62% <100.00%> (+0.61%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 63 out of 87 changed files in this pull request and generated 2 comments.

Files not reviewed (13)

ydb/_grpc/v3/draft/protos/ydb_maintenance_pb2.py: Language not supported
ydb/_grpc/v3/draft/protos/ydb_replication_pb2.py: Language not supported
ydb/_grpc/v3/draft/protos/ydb_view_pb2.py: Language not supported
ydb/_grpc/v3/draft/ydb_replication_v1_pb2.py: Language not supported
ydb/_grpc/v3/draft/ydb_view_v1_pb2.py: Language not supported
ydb/_grpc/v3/protos/ydb_query_pb2.py: Language not supported
ydb/_grpc/v3/protos/ydb_topic_pb2.py: Language not supported
ydb/_grpc/v3/ydb_table_v1_pb2.py: Language not supported
ydb/_grpc/v4/draft/protos/ydb_maintenance_pb2.py: Language not supported
ydb/_grpc/v4/draft/protos/ydb_replication_pb2.py: Language not supported
ydb/_grpc/v4/draft/protos/ydb_view_pb2.py: Language not supported
ydb/_grpc/v4/draft/ydb_replication_v1_pb2.py: Language not supported
ydb/_grpc/v4/draft/ydb_view_v1_pb2.py: Language not supported

github-actions · 2026-06-14T12:58:50Z

🌋 SLO Test Results

🟢 2 workload(s) tested — All thresholds passed

Commit: dbe5fee · View run

Workload	Thresholds	Duration	Report
sync-query	🟢 OK	10m 10s	📄 Report
sync-table	🟢 OK	10m 2s	📄 Report

Generated by ydb-slo-action

Co-authored-by: Cursor <cursoragent@cursor.com>

Move the missing-node-id check to the session and tighten the connection pool contract to accept a concrete int node id. Co-authored-by: Cursor <cursoragent@cursor.com>

Look up node connections under ConnectionsCache lock when pessimizing after NodeShutdown hints, and strip grpcio-tools version gates from v6 gRPC stubs so imports work with grpcio>=1.42.0. Co-authored-by: Cursor <cursoragent@cursor.com>

Restore stubs from main and strip grpcio version gates via generate_protoc, instead of leaving broken conflict markers or truncated files. Co-authored-by: Cursor <cursoragent@cursor.com>

Restore auto-generated stubs and generate_protoc.py to match main. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Cover attach stream wrapper, ConnectionsCache lookup, and async pool pessimize edge cases to satisfy codecov/patch threshold. Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

robot-vibe-db

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

Minor | Medium: Fire-and-forget asyncio task reference not saved — ydb/aio/pool.py:321
Minor | Low: If _pessimize_node raises, _close_session is skipped on that code path — ydb/query/session.py:172
Nit | High: No logging when session shutdown hints are received — ydb/query/session.py:164

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

robot-vibe-db · 2026-07-08T08:35:44Z

+
+        connection = cast(Optional[Connection], self._store.get_connection_by_node_id(node_id))
+        if connection is not None:
+            asyncio.get_running_loop().create_task(self._on_disconnected(connection)())


Severity: Minor
Confidence: Medium

The task created by create_task() is not saved to a variable. Per the Python docs: "Save a reference to the result of this function, to avoid a task disappearing mid-execution." Starting from Python 3.12, the event loop only keeps weak references to tasks, so an unsaved task may be garbage-collected before completing.

Additionally, if connection.close() inside _on_disconnected raises, the exception will go unhandled (only producing a Task exception was never retrieved warning).

Suggested fix: store the task and add a done-callback to discard it, e.g.:

task = asyncio.get_running_loop().create_task(self._on_disconnected(connection)()) task.add_done_callback(lambda t: t.exception() if not t.cancelled() else None)

Or collect tasks in a set with task.add_done_callback(self._background_tasks.discard).

robot-vibe-db · 2026-07-08T08:35:44Z

+        hint = response_pb.WhichOneof("session_hint")
+        if hint == "node_shutdown":
+            if self._node_id is not None:
+                self._driver._pessimize_node(self._node_id)


Severity: Minor
Confidence: Low

If _pessimize_node raises (e.g. connection.close() fails inside the sync pool's _on_disconnected), the _close_session(invalidate=True) call on line 173 is skipped. The session is eventually invalidated through the exception propagating up to _check_session_status_loop's except handler, but the recovery path is indirect.

Suggested fix — wrap the pessimization so _close_session is always reached:

if hint == "node_shutdown": if self._node_id is not None: try: self._driver._pessimize_node(self._node_id) except Exception: logger.debug("Failed to pessimize node %s", self._node_id, exc_info=True) self._close_session(invalidate=True)

robot-vibe-db · 2026-07-08T08:35:44Z

+        self._handle_attach_session_state(response_pb)
+        return common_utils.ServerStatus.from_proto(response_pb)
+
+    def _handle_attach_session_state(self, response_pb) -> None:


Severity: Nit
Confidence: High

When a NodeShutdown or SessionShutdown hint arrives, the session is closed without any log entry indicating why. The eventual stream-error log from _check_session_status_loop ("Attach stream error: …") doesn't mention the hint was the root cause, making it harder to diagnose graceful-shutdown scenarios in production.

Suggested fix — add a debug-level log at the top of each branch:

if hint == "node_shutdown": logger.debug("NodeShutdown hint received, session_id: %s, node_id: %s", self._session_id, self._node_id) ... elif hint == "session_shutdown": logger.debug("SessionShutdown hint received, session_id: %s", self._session_id) ...

robot-vibe-db · 2026-07-08T08:35:59Z

Full analysis log

Analysis performed by claude, claude-opus-4-6.

KirillKurdyukov requested a review from vgvoleg June 5, 2026 09:24

KirillKurdyukov force-pushed the feat-attach-stream branch from 397fc60 to a94ba81 Compare June 11, 2026 09:12

vgvoleg requested a review from Copilot June 11, 2026 09:45

Copilot started reviewing on behalf of vgvoleg June 11, 2026 09:46 View session

Copilot AI reviewed Jun 11, 2026

vgvoleg requested a review from Copilot June 11, 2026 10:28

Copilot started reviewing on behalf of vgvoleg June 11, 2026 10:28 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread ydb/pool.py Outdated

Comment thread ydb/_grpc/v6/ydb_table_v1_pb2_grpc.py

asmyasnikov added the SLO label Jun 11, 2026

github-actions Bot removed the SLO label Jun 11, 2026

asmyasnikov added the SLO label Jun 14, 2026

github-actions Bot removed the SLO label Jun 14, 2026

KirillKurdyukov force-pushed the feat-attach-stream branch 2 times, most recently from a0a70db to 3a583b1 Compare June 29, 2026 09:22

KirillKurdyukov and others added 8 commits July 8, 2026 10:20

feat: supported attach hint

81309ea

fix linter

86936c8

Move node pessimation to connection pools

44ed3e0

Co-authored-by: Cursor <cursoragent@cursor.com>

Require non-optional node id in _pessimize_node

dae21de

Move the missing-node-id check to the session and tighten the connection pool contract to accept a concrete int node id. Co-authored-by: Cursor <cursoragent@cursor.com>

Fix Copilot review issues for attach hint PR

4337854

Look up node connections under ConnectionsCache lock when pessimizing after NodeShutdown hints, and strip grpcio-tools version gates from v6 gRPC stubs so imports work with grpcio>=1.42.0. Co-authored-by: Cursor <cursoragent@cursor.com>

Fix v6 gRPC stubs after rebase conflict resolution

db10c46

Restore stubs from main and strip grpcio version gates via generate_protoc, instead of leaving broken conflict markers or truncated files. Co-authored-by: Cursor <cursoragent@cursor.com>

Revert unintended v6 gRPC stub changes.

7c4f60e

Restore auto-generated stubs and generate_protoc.py to match main. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove duplicate CHANGELOG entry after rebase onto main.

17cf9da

Co-authored-by: Cursor <cursoragent@cursor.com>

KirillKurdyukov force-pushed the feat-attach-stream branch from 80fb11a to 17cf9da Compare July 8, 2026 07:21

Add tests to improve patch coverage for attach hint handling.

71b827d

Cover attach stream wrapper, ConnectionsCache lookup, and async pool pessimize edge cases to satisfy codecov/patch threshold. Co-authored-by: Cursor <cursoragent@cursor.com>

vgvoleg requested a review from Copilot July 8, 2026 08:24

vgvoleg added the need_ai_review label Jul 8, 2026

Copilot started reviewing on behalf of vgvoleg July 8, 2026 08:24 View session

robot-vibe-db Bot removed the need_ai_review label Jul 8, 2026

robot-vibe-db Bot added the ai_review_in_process label Jul 8, 2026

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread tests/query/test_query_session_hints.py

robot-vibe-db Bot reviewed Jul 8, 2026

View reviewed changes

robot-vibe-db Bot added ai_reviewed and removed ai_review_in_process labels Jul 8, 2026

vgvoleg approved these changes Jul 8, 2026

View reviewed changes

vgvoleg merged commit 3054b8f into main Jul 8, 2026
35 checks passed

vgvoleg deleted the feat-attach-stream branch July 8, 2026 09:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: supported attach hint#833

feat: supported attach hint#833
vgvoleg merged 9 commits into
mainfrom
feat-attach-stream

KirillKurdyukov commented Jun 5, 2026

Uh oh!

codecov-commenter commented Jun 11, 2026 •

edited by codecov Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

robot-vibe-db Bot left a comment

Uh oh!

robot-vibe-db Bot Jul 8, 2026

Uh oh!

robot-vibe-db Bot Jul 8, 2026

Uh oh!

robot-vibe-db Bot Jul 8, 2026

Uh oh!

robot-vibe-db Bot commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

KirillKurdyukov commented Jun 5, 2026

Uh oh!

codecov-commenter commented Jun 11, 2026 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 14, 2026

🌋 SLO Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

robot-vibe-db Bot left a comment

Choose a reason for hiding this comment

AI Review Summary

Critical issues

Other findings

Uh oh!

robot-vibe-db Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

robot-vibe-db Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

robot-vibe-db Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

robot-vibe-db Bot commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Jun 11, 2026 •

edited by codecov Bot

Loading