chore: remove dead table-service transaction machinery - #595
Open
sshaplygin wants to merge 1 commit into
Open
Conversation
Part of ydb-platform#518. ydb-platform#518 asks to remove the old transaction API once the query service can span tables and topics (ydb-platform#340). ydb-platform#340 landed and closed on 2026-07-07, and the public side of that removal already happened in the 0.16.0 table/query split: `TableClient` no longer runs YQL or transactions, and topic transactions are built on the query-service `Transaction` via `QueryTxHook`. What remained was the raw plumbing underneath, which no longer has a caller anywhere in the repository: - `execute_data_query.rs`, `transaction_control.rs`, `commit_transaction.rs`, `rollback_transaction.rs` - the matching `RawTableClient::{execute_data_query, commit_transaction, rollback_transaction}` methods - `query_stats.rs`, whose `RawQueryStatMode` existed only to configure `ExecuteDataQuery` - the `Operation` impls for `ExecuteDataQueryResponse`, `CommitTransactionResponse` and `RollbackTransactionResponse` The `commit_transaction` / `rollback_transaction` calls that remain in `client_query/exec.rs` are the query service's own, in `raw_query_service`; likewise the surviving `RawTxMode` is the query service type, unrelated to the table one removed here. No public API changes: every removed item was `pub(crate)` inside a `pub(crate)` module and never re-exported. Verified against ydbplatform/local-ydb:nightly: 302 tests pass with --include-ignored, matching the count on master. The seven cross-service transaction tests (topic writer/reader commit, rollback, redelivery, offset advance) pass unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 86.91% 87.39% +0.48%
==========================================
Files 198 193 -5
Lines 19492 19373 -119
==========================================
- Hits 16941 16931 -10
+ Misses 2551 2442 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #518.
Context
#518 asks to remove the old transaction API once the query service can span tables and topics (#340). Checking the current state before deleting anything:
TableClientno longer runs YQL or transactions, there are no#[deprecated]transaction items anywhere, andretry_transactionis alreadyretry_tx.TransactionviaQueryTxHook—TopicWriterTx::new(.., tx: &mut Transaction),reader.tx_reader(&mut tx),reader.pop_batch_in_tx(&mut tx). All seven integration tests pass against a live server: writer commit/rollback, reader commit/rollback/redelivery/offset-advance, andread_topic_message_in_transaction.So the API #518 targeted is gone. What remained is the raw plumbing underneath it, which no longer has a caller anywhere in the repository.
What this removes
execute_data_query.rs,transaction_control.rs,commit_transaction.rs,rollback_transaction.rsRawTableClient::{execute_data_query, commit_transaction, rollback_transaction}query_stats.rsRawQueryStatModeexisted solely to configureExecuteDataQueryOperationimpls forExecuteDataQueryResponse,CommitTransactionResponse,RollbackTransactionResponse323 lines deleted, 4 added.
Two things that look similar but are not touched: the
commit_transaction/rollback_transactioncalls inclient_query/exec.rsare the query service's own inraw_query_service, and the survivingRawTxModeis the query-service type, distinct from the table one removed here.No public API changes. Every removed item was
pub(crate)inside apub(crate)module and never re-exported.Verification
Against
ydbplatform/local-ydb:nightly, the image CI uses:Note for reviewers
Two follow-ups I deliberately left alone, since neither is transaction-related and both belong in their own change:
RawTableClient::explain_data_queryis also uncalled, as isexplain_data_query.rs.docker-compose.yamlpinslocal-ydb:latest, while CI uses:nightly. On:latest, 11 pre-existing integration tests fail withUnknown name: $val.Whether #518 can now be closed is a maintainer call — this finishes the mechanical part, but the issue was written against a broader API that the 0.16.0 refactor already removed.
🤖 Generated with Claude Code