Skip to content

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Oct 13, 2025

Changelog entry

Retry NotifyBridgeSyncFinished command when racing

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This patch makes BSC retry NotifyBridgeSyncFinished command when it is racing with newer configuration.

mregrock
mregrock previously approved these changes Oct 13, 2025
Copy link

🟢 2025-10-13 11:56:03 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Oct 13, 2025

2025-10-13 11:56:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0fde8d8 has started.
2025-10-13 11:56:24 UTC Artifacts will be uploaded here
2025-10-13 12:00:10 UTC ya make is running...
🔴 2025-10-13 12:03:40 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 13, 2025

2025-10-13 11:56:17 UTC Pre-commit check linux-x86_64-release-asan for 0fde8d8 has started.
2025-10-13 11:56:30 UTC Artifacts will be uploaded here
2025-10-13 12:00:07 UTC ya make is running...
🔴 2025-10-13 12:04:03 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the bsdc/retry-notify-bridge-sync-finished branch from f2bd1fa to 293233c Compare October 13, 2025 12:15
@alexvru alexvru enabled auto-merge (squash) October 13, 2025 12:17
Copy link

github-actions bot commented Oct 13, 2025

2025-10-13 12:22:01 UTC Pre-commit check linux-x86_64-release-asan for d605a80 has started.
2025-10-13 12:22:55 UTC Artifacts will be uploaded here
2025-10-13 12:27:08 UTC ya make is running...
🟡 2025-10-13 14:21:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15994 15519 0 174 286 15

🟢 2025-10-13 14:21:38 UTC Build successful.
🟢 2025-10-13 14:22:03 UTC ydbd size 3.7 GiB changed* by +23.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ff2b01d merge: d605a80 diff diff %
ydbd size 4 025 781 648 Bytes 4 025 805 768 Bytes +23.6 KiB +0.001%
ydbd stripped size 1 495 229 728 Bytes 1 495 241 632 Bytes +11.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 13, 2025

2025-10-13 12:32:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for d605a80 has started.
2025-10-13 12:33:06 UTC Artifacts will be uploaded here
2025-10-13 12:36:39 UTC ya make is running...

Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants