Skip to content

YQ-4798 added feature flag for topic client AS threads usage #26987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

YQ-4798 added feature flag for topic client AS threads usage #26987

merged 1 commit into from
Oct 16, 2025

Conversation

GrigoriyPA
Copy link
Collaborator

Changelog entry

Added feature flag for topic client AS threads usage

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner October 16, 2025 09:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 09:16:24 UTC Pre-commit check linux-x86_64-release-asan for bfa0584 has started.
⚪ 2025-10-16 09:16:28 UTC Artifacts will be uploaded here
⚪ 2025-10-16 09:20:31 UTC ya make is running...
⚫ 2025-10-16 09:37:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 09:16:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for bfa0584 has started.
⚪ 2025-10-16 09:16:45 UTC Artifacts will be uploaded here
⚪ 2025-10-16 09:20:58 UTC ya make is running...
⚫ 2025-10-16 09:37:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

🟢 2025-10-16 09:17:20 UTC The validation of the Pull Request description is successful.

yumkam
yumkam reviewed Oct 16, 2025
View reviewed changes
yumkam
yumkam reviewed Oct 16, 2025
View reviewed changes
ydb/core/fq/libs/control_plane_storage/ydb_control_plane_storage_queries.cpp
success.Apply([=](const auto& future) {
TDuration delta = TInstant::Now() - startTime;
LWPROBE(DescribeQueryRequest, scope, user, queryId, delta, byteSize, future.GetValue());
LWPROBE(GetQueryStatusRequest, scope, user, queryId, delta, byteSize, future.GetValue());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(unrelated drive-by-fix, but ok)

yumkam
yumkam previously approved these changes Oct 16, 2025
View reviewed changes
@GrigoriyPA GrigoriyPA requested a review from yumkam October 16, 2025 09:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 09:41:09 UTC Pre-commit check linux-x86_64-release-asan for 3ed95e3 has started.
⚪ 2025-10-16 09:41:23 UTC Artifacts will be uploaded here
⚪ 2025-10-16 09:45:39 UTC ya make is running...
🟡 2025-10-16 12:25:19 UTC ydbd size 3.8 GiB changed* by +185.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e1f3ac8 merge: 3ed95e3 diff diff %
ydbd size 4 033 075 488 Bytes 4 033 265 712 Bytes +185.8 KiB +0.005%
ydbd stripped size 1 497 937 632 Bytes 1 498 000 992 Bytes +61.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-10-16 12:25:20 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 09:41:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3ed95e3 has started.
⚪ 2025-10-16 09:41:38 UTC Artifacts will be uploaded here
⚪ 2025-10-16 09:45:52 UTC ya make is running...
🟡 2025-10-16 12:06:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41240 38457 0 4 2752 27

⚪ 2025-10-16 12:06:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-16 12:24:51 UTC ydbd size 2.3 GiB changed* by +5.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2dade7c merge: 3ed95e3 diff diff %
ydbd size 2 424 167 608 Bytes 2 424 173 216 Bytes +5.5 KiB +0.000%
ydbd stripped size 516 061 640 Bytes 516 062 856 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-10-16 12:24:53 UTC Check cancelled

uzhastik
uzhastik reviewed Oct 16, 2025
View reviewed changes
uzhastik
uzhastik reviewed Oct 16, 2025
View reviewed changes
@GrigoriyPA GrigoriyPA force-pushed the YQ-4798-add-feature-flag-for-using-AS-threads-in-topic-client branch from 5d6af28 to 00c0767 Compare October 16, 2025 12:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 12:27:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 975bb01 has started.
⚪ 2025-10-16 12:27:42 UTC Artifacts will be uploaded here
⚪ 2025-10-16 12:31:53 UTC ya make is running...
🟡 2025-10-16 14:54:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41246 38470 0 6 2743 27

⚪ 2025-10-16 14:54:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-16 15:12:11 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
644 (only retried tests) 624 0 0 0 20

🟢 2025-10-16 15:12:13 UTC Build successful.
🟢 2025-10-16 15:12:30 UTC ydbd size 2.3 GiB changed* by +5.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0cf099b merge: 975bb01 diff diff %
ydbd size 2 424 209 616 Bytes 2 424 215 160 Bytes +5.4 KiB +0.000%
ydbd stripped size 516 072 648 Bytes 516 073 800 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

⚪ 2025-10-16 12:28:08 UTC Pre-commit check linux-x86_64-release-asan for 975bb01 has started.
⚪ 2025-10-16 12:28:12 UTC Artifacts will be uploaded here
⚪ 2025-10-16 12:32:14 UTC ya make is running...
🟡 2025-10-16 15:10:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18025 17573 0 147 288 17

🟢 2025-10-16 15:10:58 UTC Build successful.
🟢 2025-10-16 15:11:21 UTC ydbd size 3.8 GiB changed* by +7.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0cf099b merge: 975bb01 diff diff %
ydbd size 4 033 342 136 Bytes 4 033 350 216 Bytes +7.9 KiB +0.000%
ydbd stripped size 1 498 039 776 Bytes 1 498 044 000 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit eef470e into ydb-platform:main Oct 16, 2025
13 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-4798-add-feature-flag-for-using-AS-threads-in-topic-client branch October 16, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik approved these changes

@kardymonds kardymonds Awaiting requested review from kardymonds

@yumkam yumkam Awaiting requested review from yumkam

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GrigoriyPA @yumkam @uzhastik