-
Notifications
You must be signed in to change notification settings - Fork 727
fetch only requested portion columns #27002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes data fetching in the columnshard component by reducing the volume of reads during deduplication operations. The changes ensure that only the requested columns are fetched and assembled, rather than reading entire portions.
Key Changes
- Modified
TAskDataStep
to correctly apply column filtering based on the presence ofColumnIds
- Updated
TAssembleDataStep
to accept and use column IDs for creating filtered schemas - Integrated
TFilteredSnapshotSchema
to limit schema operations to only requested columns
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
ydb/core/tx/columnshard/data_reader/fetching_steps.h | Fixed conditional logic in TAskDataStep , added column filtering to TAssembleDataStep via TFilteredSnapshotSchema , and updated constructor to accept column IDs |
ydb/core/tx/columnshard/data_reader/fetcher.cpp | Updated instantiation of TAssembleDataStep to pass entityIds parameter in both fetching methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
private: | ||
std::shared_ptr<NReader::NCommon::TColumnsSetIds> ColumnIds; | ||
|
||
private: |
Copilot
AI
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate private:
access specifier. The second private:
on line 313 is redundant since line 310 already establishes private access. Remove the duplicate specifier.
private: |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
как это вообще работало?)
Changelog entry
Reduce volume of reads for deduplication on CS
Changelog category
Description for reviewers
...