This repository was archived by the owner on Feb 8, 2025. It is now read-only.
WIP: s3bids deprecation #943
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beginning to work towards s3bids deprecation.
Collaborator
|
This says WIP. What else is needed to put this over the finish line? |
Contributor
Author
|
If you think that's a good idea, I was thinking of raising a deprecation warning whenever s3bids is imported. Something like eca0074 |
Contributor
Author
|
I guess we can be more precise and set ourselves a kind of deadline, by saying something like: "will be removed no later than pyAFQ 2.0", or somesuch. |
Contributor
Author
|
BTW: if we are punting this as far as 2.0, I think that it's fine to go ahead with the release with s3bids in it, and then add this warning in the 1.0 cycle. |
This means that the warning will only be raised upon calling a deprecated function, or initialization of a deprecated class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #908