[review-mirror] microsoft/PowerToys#49194

[yeelam-gordon]

Review sandbox mirror of microsoft#49194 (branch dev/mjolley/dev-mjolley-fast-first-paint). Opened by PR-autopilot for Copilot review + local build validation. Not for merge.

[Copilot]

Pull request overview

This PR updates CmdPal’s main-page ranking and rendering pipeline to improve “fast first paint” behavior and make ordering more deterministic and configurable. It introduces a tier-based rank packing model (so strong textual matches can’t be leapfrogged), replaces the old recent-command “bucket” heuristic with time-decayed frecency (persisted across restarts), adds a per-provider “search weight” nudge exposed in Settings, and re-scores slow global fallbacks on the render path so late-arriving dynamic titles fold in safely.

Changes:

• Implement tiered ranking via packed scores (RankTier + clamped within-tier score), including alias and fallback-floor behavior, plus a small per-provider within-tier bonus.
• Replace recent-command weighting with persisted, time-decayed frecency (recency half-life + log-frequency), including a capped history store and cached lookup index.
• Add unit tests covering fast-first-paint invariants, provider weighting, frecency decay/frequency, history cap/serialization, and alias-substring-only regression; wire a “Search weight” ComboBox into the extension settings UI.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/modules/cmdpal/Tests/Microsoft.CmdPal.UI.ViewModels.UnitTests/RecentCommandsTests.cs	Updates/adds tests for new frecency model, history cap/index invalidation, migration behavior, serialization round-trip, and tier invariants.
src/modules/cmdpal/Tests/Microsoft.CmdPal.UI.ViewModels.UnitTests/ProviderWeightingTests.cs	New tests validating provider weight bonus behavior, tier-boundary invariants, and provider settings JSON compatibility.
src/modules/cmdpal/Tests/Microsoft.CmdPal.UI.ViewModels.UnitTests/FastFirstPaintTests.cs	New guardrail tests validating deterministic first paint and safe late fallback fold-in via render-path re-scoring.
src/modules/cmdpal/Microsoft.CmdPal.UI/Strings/en-us/Resources.resw	Adds localized strings and automation name for the new “Search weight” settings card and options.
src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/ExtensionPage.xaml	Adds “Search weight” ComboBox bound to ProviderSettingsViewModel.SearchWeightIndex.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/RecentCommandsManager.cs	Implements persisted frecency model (time decay + log frequency), increases history cap, and adds cached index invalidation.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ProviderSettingsViewModel.cs	Adds SearchWeightIndex (ComboBox-friendly) to persist provider weight setting.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/ProviderSettings.cs	Introduces ProviderSearchWeight enum and persists ProviderSettings.SearchWeight with Normal default.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/HistoryItem.cs	Adds LastUsed timestamp to support real time-decay frecency.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/MainListRanker.cs	New tier-based ranker: tier classification, within-tier scoring, packed score encoding, acronym/word-boundary helper, provider bonus.
src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Commands/MainListPage.cs	Switches scoring to tiered packed scores, adds provider weight lookup, and defers global fallback scoring to render path via snapshot + re-score helper.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (85)

accepteula
autorun
BEARNING
CABAC
choosecharacter
CLASSNOTREGISTERED
clipboardhistor
cmb
commicrosoftcmd
dedup
endgroup
endtask
exps
extensiononly
filenameonly
flippable
foregrounding
Freelook
Godot
gotcha
greenfield
hesiate
hideleadingdigi
hidethefileexte
Hmmss
HTBOTTOM
HTBOTTOMLEFT
HTLEFT
HTMLPEEKMARKER
HTNOWHERE
HTRIGHT
HTTOP
HTTOPLEFT
HTTOPRIGHT
idempotently
ILC
inh
initialises
interactable
itm
keepme
launchgame
letterboxed
letterboxing
logissue
Mdd
Miracast
Mnu
MODULEUI
msgamelaunch
NETSDK
nojekyll
nonelevated
olk
oneline
ouside
pasteas
pasteasjson
pasteasmarkdown
pasteasplaintex
PJT
psexec
ptbk
PTLONGPATH
quser
qwinsta
racey
REGDB
relogin
respawns
rewordings
rgt
screenshotting
sendinput
SETFOREGROUNDLOCKTIMEOUT
sideload
sideloading
tfm
Tgl
timestamped
uncomposited
unsubscribes
VKs
watsonportal
zzz

These words are not needed and should be removed

ATRIOX Autorun Dedup Gotchas intput MTND NONELEVATED NOTXORPEN nullability pfo ssf TILLSON Unsubscribes Uptool VISEGRADRELAY WKSG

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:yeelam-gordon/PowerToys.git repository
on the prreview/49194/dev/mjolley/dev-mjolley-fast-first-paint branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/yeelam-gordon/PowerToys/actions/runs/29227197333/attempts/1' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
@check-spelling-bot apply updates.

Forbidden patterns 🙅 (7)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

Articles generally shouldn't be used without a noun and a verb

• Perhaps you're missing a verb between the noun and the second article.
• Or, perhaps you should remove the first verb and treat the intervening word as a verb?
• In some cases you should add a , between the noun and the second article.

\s(?:an?|the(?! action))\s(?!way|wh|(?:how|priori)\b)[A-Za-z][a-z]+[a-qs-z]\s(?:a(?! (?:bit|few|little|lot|posteriori))n?|the(?! same))\s

Should be ; otherwise or . Otherwise

https://study.com/learn/lesson/otherwise-in-a-sentence.html

, [Oo]therwise\b

Should be preexisting

[Pp]re[- ]existing

Should be nonexistent

\b[Nn]o[nt][- ]existent\b

Should be into

when not phrasal and when in order to would be wrong:
https://thewritepractice.com/into-vs-in-to/

(?<!opt)\sin to\s(?!if\b)

Should be prepopulate

[Pp]re[- ]populate

In English, duplicated words are generally mistakes

There are a few exceptions (e.g. "that that").
If the highlighted doubled word pair is in:

• code, write a pattern to mask it.
• prose, have someone read the English before you dismiss this error.

\s([A-Z]{3,}|[A-Z][a-z]{2,}|[a-z]{3,})\s\g{-1}\s

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spell-check/patterns.txt:

# Automatically suggested patterns

# hit-count: 7 file-count: 3
# Non-English
# Even repositories expecting pure English content can unintentionally have Non-English content... People will occasionally mistakenly enter [homoglyphs](https://en.wikipedia.org/wiki/Homoglyph) which are essentially typos, and using this pattern will mean check-spelling will not complain about them.
# .
# If the content to be checked should be written in English and the only Non-English items will be people's names, then you can consider adding this.
# .
# Alternatively, if you're using check-spelling v0.0.25+, and you would like to _check_ the Non-English content for spelling errors, you can. For information on how to do so, see:
# https://docs.check-spelling.dev/Feature:-Configurable-word-characters.html#unicode
[a-zA-Z]*[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3}[a-zA-ZÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]*|[a-zA-Z]{3,}[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź]|[ÀÁÂÃÄÅÆČÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝßàáâãäåæčçèéêëìíîïðñòóôõöøùúûüýÿĀāŁłŃńŅņŒœŚśŠšŜŝŸŽžź][a-zA-Z]{3,}

Alternatively, if a pattern suggestion doesn't make sense for this project, add a # to the beginning of the line in the candidates file with the pattern to stop suggesting it.

Errors and Notices ❌ (3)

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

❌ Errors and Notices	Count
ℹ️ candidate-pattern	3
❌ check-file-path	4
❌ forbidden-pattern	19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.