Skip to content

Error Handling in Directory Creation #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeHopen
Copy link
Contributor

@DeHopen DeHopen commented May 14, 2025

@yegor256

This Pull request solves this problem: #1341

@yegor256
Copy link
Owner

@DeHopen we can't merge it, because the build is not green. Also, read this: https://www.yegor256.com/2025/04/19/dont-merge-into-broken-master.html

@DeHopen
Copy link
Contributor Author

DeHopen commented May 15, 2025

@yegor256

CI is green

@DeHopen
Copy link
Contributor Author

DeHopen commented May 16, 2025

@yegor256 ping

@yegor256
Copy link
Owner

@DeHopen how do you know the problem is solved? Would be nice to reproduce it first with a test, and then fix

@DeHopen
Copy link
Contributor Author

DeHopen commented May 16, 2025

@yegor256

I tested it and it works as it should.

@yegor256
Copy link
Owner

@DeHopen I trust you. However, other contributors may have doubts.

@DeHopen
Copy link
Contributor Author

DeHopen commented May 17, 2025

@yegor256

Then can you count this PR? I did something useful, but because of others you can't merge, it's enough for me that it counts

@DeHopen
Copy link
Contributor Author

DeHopen commented May 19, 2025

@yegor256

ping

@yegor256
Copy link
Owner

@DeHopen we need a test to make sure new functionality works

@DeHopen
Copy link
Contributor Author

DeHopen commented May 20, 2025

@yegor256

When should we expect functional tests?

@DeHopen
Copy link
Contributor Author

DeHopen commented May 21, 2025

@yegor256 ping

1 similar comment
@DeHopen
Copy link
Contributor Author

DeHopen commented May 22, 2025

@yegor256 ping

@yegor256
Copy link
Owner

@DeHopen pong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants