-
Notifications
You must be signed in to change notification settings - Fork 118
Error Handling in Directory Creation #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@DeHopen we can't merge it, because the build is not green. Also, read this: https://www.yegor256.com/2025/04/19/dont-merge-into-broken-master.html |
CI is green |
@yegor256 ping |
@DeHopen how do you know the problem is solved? Would be nice to reproduce it first with a test, and then fix |
I tested it and it works as it should. |
@DeHopen I trust you. However, other contributors may have doubts. |
Then can you count this PR? I did something useful, but because of others you can't merge, it's enough for me that it counts |
ping |
@DeHopen we need a test to make sure new functionality works |
When should we expect functional tests? |
@yegor256 ping |
1 similar comment
@yegor256 ping |
@DeHopen pong |
@yegor256
This Pull request solves this problem: #1341