fix(build): replace node-sass with sass and disable css-purge shorten#313
Merged
yegor256 merged 1 commit intoyegor256:masterfrom May 25, 2025
Merged
Conversation
- Replaced node-sass with sass to fix build issues related to Visual Studio dependencies. - Added 'shorten: false' to css-purge options to prevent incorrect shortening of border widths.
Owner
|
@ManiShah7 awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @yegor256,
Notes
I couldn’t install dependencies properly due to issues with node-sass (which requires Visual Studio build tools). Although I installed Visual Studio, the problem persisted. To fix this, I replaced node-sass with sass (Dart Sass) which has better compatibility and easier installation.
If you prefer not to replace node-sass with sass, you can simply merge the part of this pull request that adds:
to the css_purge task in the Gruntfile.
Description
node-sasswithsassto fix build issues related to Visual Studio dependencies.shorten: falseoption tocss-purgeto prevent incorrect shortening of border widths.If you have any questions or need me to adjust anything, please feel free to let me know. I’m happy to help!
fixes #309