Fix edge runtime #104
Merged
Fix edge runtime #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bel/runtime to version 7.27.4
…s and updating styles
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with the edge runtime by removing unused font-loading code and updating styling in the OG image API endpoint, and by removing turbopack flags from npm scripts.
- Removed asynchronous font preloading in src/pages/api/og.tsx and updated inline styling for a more modern look.
- Updated package.json scripts to remove turbopack-related flags.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/pages/api/og.tsx | Removed font data preloading and updated styling for improved consistency. |
| package.json | Removed turbopack flags from the dev and build scripts. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
src/pages/api/og.tsx:29
- The h1 element is still referencing 'FiraSans-Bold' in its inline style, but the font data for FiraSans-Bold has been removed. Consider updating the font reference or adding the necessary font data to avoid unintended font fallback.
fontFamily: "FiraSans-Bold"
package.json:7
- The removal of the '--turbopack' flag from the 'dev' and 'build' scripts may affect build performance. Please confirm that this change was intentional and that performance has been validated.
"dev": "next dev",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Preview or Screenshot