Skip to content

chore(deps): switch to tinyglobby#615

Closed
benmccann wants to merge 1 commit into
yeoman:mainfrom
benmccann:tinyglobby
Closed

chore(deps): switch to tinyglobby#615
benmccann wants to merge 1 commit into
yeoman:mainfrom
benmccann:tinyglobby

Conversation

@benmccann

@benmccann benmccann commented Jun 26, 2025

Copy link
Copy Markdown

Purpose of this pull request?

  • Documentation update
  • Bug fix
  • Enhancement
  • Other, please explain:

What changes did you make?

Switched from globby to tinyglobby

I'm not sure why npm ci is failing. Maybe this project uses an old version of npm? It works fine for me locally

Is there anything you'd like reviewers to focus on?

https://npmgraph.js.org/?q=tinyglobby - 2 dependencies
https://npmgraph.js.org/?q=globby - 23 dependencies

@socket-security

socket-security Bot commented Jun 26, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtinyglobby@​0.2.13 ⏵ 0.2.1410010091 +187100

View full report

@JoshuaKGoldberg

Copy link
Copy Markdown
Contributor

Is there anything you'd like reviewers to focus on?

I am happy to now have https://e18e.dev/guide/advocacy.html to link for things like this 🙂.

Specifically, https://e18e.dev/guide/advocacy.html#explaining-changes:

In general, it's best to demonstrate tangible benefits that are specific to the project.
...
If a dependency cleanup is meant to reduce the size of a project's dependency tree, show the actual change to the tree.
...
An isolated dependency graph (e.g. via <npmgraph.js.org>) can be useful to give a quick overview of the difference between two dependencies. However, sometimes it is not representative of how the overall project's dependency tree will be affected. This can be for various reasons, such as the project pulling the same dependencies in elsewhere.

Switching to draft for now. Please post some compelling evidence for why this change is net for the better.

@JoshuaKGoldberg
JoshuaKGoldberg marked this pull request as draft June 26, 2025 17:01
@benmccann

Copy link
Copy Markdown
Author

Ah, thanks for taking a close look at this one @JoshuaKGoldberg. It may make sense to hold off on this for a bit until the next release of mem-fs-editor. That package has switched to tinyglobby, but I missed that the changes are not yet released. So this change in the short-term would introduce a second globbing library. However, once that change is released, I think it'd make sense to move forward with this change so that this package doesn't end up with two globbing libraries in its dependency tree.

@JoshuaKGoldberg

Copy link
Copy Markdown
Contributor

Good to know! Closing this in the meantime.

@MichaelDeBoey

Copy link
Copy Markdown

@JoshuaKGoldberg mem-fs-editor v12 now uses tinyglobby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants