fix: add override for deprecated #845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
Mar 20, 2025
Contributor
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
👋 Thanks for sending this in! I don't think this is the strategy we'll want to take, though. It's cleaner -and healthier for the ecosystem!- to report problems upstream to dependents. Once the dependents fix those problems we won't have to do any fancy things with them.
Member
|
Fixed in gulpjs/vinyl#162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request?
What changes did you make?
overridefrom deprecatedclone-statsto its modern forknpm-shrinkwrap.jsonto the package to ensure theoverrideis respected duringnpm install -gIs there anything you'd like reviewers to focus on?
Fixes #844