Convert to ESM #862
Merged
Convert to ESM #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix 787 - Switch from CJS to ESM * switch project to type=module * adopt import/export syntax throughout codebase * update meow (ESM support since v10) * remove global-tunnel-ng branch since we're > Node 10 * replace proxyquire (no ESM) with testdouble * replace nyc (no ESM) with c8 * shim __dirname * remove unused --no-update-notifier in CLI * [WIP] disable failing tabtab test * Make sure we're resetting td mocks
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
mshima
commented
Apr 4, 2025
mshima
commented
Apr 4, 2025
mshima
commented
Apr 5, 2025
UlisesGascon
approved these changes
Apr 5, 2025
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
This is big change! Thanks for making it possible ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #787
Based on #859
Fix 787 - Switch from CJS to ESM
switch project to type=module
adopt import/export syntax throughout codebase
update meow (ESM support since v10)
remove global-tunnel-ng branch since we're > Node 10
replace proxyquire (no ESM) with testdouble
replace nyc (no ESM) with c8
shim __dirname
remove unused --no-update-notifier in CLI
[WIP] disable failing tabtab test
Make sure we're resetting td mocks
Purpose of this pull request?
What changes did you make?
Is there anything you'd like reviewers to focus on?