chore: use async/await Promises instead of .then/.catch Promises #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Nov 5, 2025
| assert.rejects( | ||
| this.router.navigate.bind(this.router, 'invalid route name'), | ||
| 'No routes called: invalid route name', | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
Example failure of this test on
https://github.com/yeoman/yo/actions/runs/19107048177/job/54593675005?pr=918:
1) Router
#navigate()
throws on invalid route name:
AssertionError [ERR_ASSERTION]: Missing expected exception.
at Context.<anonymous> (file:///Users/runner/work/yo/yo/test/router.js:59:14)
Two existing problems with the test:
- It's
this.router, notthis.route - The function returns a Promise, so the test should be testing what it rejects, not throws
Previously it was synchronously throwing an error because this was undefined (yay, JavaScript quirks!). Switching from synchronous Promise creation to async changes the code to all be asynchronous. Now it asynchronously rejects (throws) the No routes called: ${name}.
mshima
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request?
Fixes #509.
What changes did you make?
Replaces all remaining uses of
.then/.catchwithasync/await.Is there anything you'd like reviewers to focus on?
The issue is actually for moving from the older
cbcallbacks to Promises. That'd already been done. This moves the codebase further along.