Conversation
| - test-mysql-8.0.44 | ||
| - test-mysql-8.4 | ||
| - test-mysql-9.5.0 | ||
|
|
There was a problem hiding this comment.
See https://hub.docker.com/_/mysql/ for available versions
| volumes: | ||
| - db_data:/var/lib/postgresql/data | ||
| - db_data:/var/lib/postgresql | ||
| environment: |
There was a problem hiding this comment.
PG threw an error when I tried to run it as such; apparently versions of PG 18+ want to store their data in /var/lib/postgresql/$MAJOR_VERSION
| (snip-json-extract-numeric params) | ||
| (#{:string :json} datatype) | ||
| (snip-json-extract-string params)))) | ||
| (-snip-val [_ params] |
There was a problem hiding this comment.
bool is actually int under the hood in sql, which is why it's "numeric"
|
|
||
| -- :snip snip-json-extract-string | ||
| JSON_UNQUOTE(JSON_EXTRACT(:i:col, :sql:path-str)) | ||
|
|
There was a problem hiding this comment.
the +0 is to force a numeric cast
| (doseq [stmt-id @triggers-to-offer] | ||
| (react-init/offer-trigger! reaction-channel stmt-id)) | ||
| result)) | ||
| (-get-statements |
There was a problem hiding this comment.
rather than triggering reactions immediately after insertion, stores statement ids and sends them to reaction channel if and only if transaction completes. If transaction does not complete, rolls back all statements in transaction, and sends no ids to reaction channel. Atom is local to the fn and is garbage collected once fn returns.
There was a problem hiding this comment.
(updated to use return value rather than atom)
| (let [before (count (str (int (Math/floor v)) ))] | ||
| (trunc v (- 15 before))) | ||
| v))))) | ||
|
|
There was a problem hiding this comment.
truncates test data to 15 significant digits. This is necessary b/c MySQL can't handle more than that in JSON.
cliffcaseyyet
left a comment
cliffcaseyyet
left a comment
There was a problem hiding this comment.
Some small comments. Also obviously the bigger thing from standup.
milt
left a comment
milt
left a comment
There was a problem hiding this comment.
Pending some documentation stuff (see comments) this is looking good
There was a problem hiding this comment.
good by me. wait for @milt to approve before you merge.
3 participants
8.0.44,8.4,9.5.0exe, appropriate test commands)bin/run_mysql.sh(do we want this?)dev-resources/mysql/docker-compose.ymltest-mysqlprofile inconfig.ednjson_extractimplementation that works in both MySQL and MariaDB