Skip to content

Version Promiscuity #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milt merged 4 commits into from
Nov 11, 2025
Merged

Version Promiscuity #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cb7ac7
dev version of LRS with permissive versions
milt Nov 7, 2025
eeb2dfa
test for permissive versions
milt Nov 7, 2025
9952ff2
release of LRS lib
milt Nov 7, 2025
fe31018
bind the right thing to prevent test error
milt Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
xyz.capybara/clamav-client {:mvn/version "2.1.2"}
;; Yet Analytics deps
com.yetanalytics/lrs
{:mvn/version "1.4.0"
{:mvn/version "1.4.2"
:exclusions [org.clojure/clojure
org.clojure/clojurescript
com.yetanalytics/xapi-schema]}
Expand Down
31 changes: 29 additions & 2 deletions src/test/lrsql/lrs_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
(ns lrsql.lrs-test
(:require [clojure.test :refer [deftest testing is use-fixtures]]
(:require [clojure.test :refer [deftest testing is use-fixtures are]]
[clojure.string :as cstr]
[clojure.walk :as walk]
[com.stuartsierra.component :as component]
Expand All @@ -8,7 +8,9 @@
[lrsql.test-support :as support]
[lrsql.test-constants :as tc]
[lrsql.util :as u]
[xapi-schema.spec :as xs]))
[xapi-schema.spec :as xs]
[babashka.curl :as curl]
[cheshire.core :as json]))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Init Test Config
Expand Down Expand Up @@ -1447,3 +1449,28 @@
activity-prof-id-params)))

(component/stop sys')))

(deftest accept-version-test
(let [lrs (component/start (support/test-system))]
(testing "Accepts versions 1.0.0-1.0.3"
(try
(are [version-header
result-status]
(= result-status
(:status
(curl/post
"http://localhost:8080/xapi/statements"
{:basic-auth ["username" "password"]
:headers {"X-Experience-API-Version" version-header
"Content-Type" "application/json;"}
:body (json/generate-string test-statements)
:throw false})))
"0.9.5" 400
"1.0.0" 200
"1.0.1" 200
"1.0.2" 200
"1.0.3" 200
"1.0.4" 400
"2.0.0" 200)
(finally
(component/stop lrs))))))
Loading