Skip to content

Add migration link changelog #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

paul-ohl
Copy link

Description

I added a link to the migration guides at the top of the changelog.
Since the website did not have an index for the migration guides, I added it.
And I also used that opportunity to fix the changelog tests which were broken due to username changes.

Fixes #3213

Checklist

  • I have reviewed my own code
  • I have added tests (Technically I fixed some tests)

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run prettier to make the CI green?

cd website
npm run fmt:write

@paul-ohl
Copy link
Author

I'm sorry, it may be a bit of a stupid question, but is it possible to check the CI before pushing to remote?

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit b55aa96):

https://yew-rs--pr3471-add-migration-link-c-7s5dw056.web.app

(expires Wed, 25 Oct 2023 07:39:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@paul-ohl paul-ohl requested a review from ranile October 22, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to migration guides at the top of changelog
2 participants