Fix segfault trying to lock/unlock the master lock from unregistered …#125
Merged
ygrek merged 1 commit intoygrek:masterfrom Jan 26, 2025
Merged
Fix segfault trying to lock/unlock the master lock from unregistered …#125ygrek merged 1 commit intoygrek:masterfrom
ygrek merged 1 commit intoygrek:masterfrom
Conversation
…red thread A thread that was never registered should not call enter_blocking_section or leave_blocking_section, as it cannot hold the master lock. This can cause segfaults in some cases.
carlonluca
force-pushed
the
fix-ocaml-lock
branch
from
76995c7 to
224fa16
Compare
Owner
|
did you check that these functions are never called directly from ocaml thread? also, curious, how did this work until now then? |
Contributor
Author
|
The only call to ml_gethostbyname I could find is here: https://github.com/ygrek/mldonkey/blob/master/src/utils/lib/stubs_c.c#L835. The dns_thread calls it when there is a request. |
Owner
|
this is curious |
ygrek
approved these changes
Jan 26, 2025
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…thread
A thread that was never registered should not call enter_blocking_section or leave_blocking_section, as it cannot hold the master lock. This can cause segfaults in some cases.