Skip to content

Fix HttpWatch tests #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Mar 5, 2025

HttpWatch changed the formatting of the returned JSON. Normalize it by removing all whitespace.

HttpWatch changed the formatting of the returned JSON. Normalize it by
removing all whitespace.
@falbrechtskirchinger falbrechtskirchinger changed the title Fix HTTPWatch tests Fix HttpWatch tests Mar 5, 2025
@yhirose
Copy link
Owner

yhirose commented Mar 5, 2025

@falbrechtskirchinger thanks for taking care of this issue! Do you know why some checks failed?

@falbrechtskirchinger
Copy link
Contributor Author

@falbrechtskirchinger thanks for taking care of this issue! Do you know why some checks failed?

Both PRs combined should fix all the issues. I'll run both commits on one branch through CI to confirm.

@falbrechtskirchinger
Copy link
Contributor Author

Link to CI run: https://github.com/falbrechtskirchinger/cpp-httplib/actions/runs/13692176609
Link to the branch showing both commits: https://github.com/falbrechtskirchinger/cpp-httplib/commits/refs/heads/fix-tests/

Interestingly, YahooRedirectTest3.SimpleInterface_Online failed once. I checked with my browser and saw that https://yahoo.com/ can return a status code 307 Temporary Redirect and redirect to a location other than https://www.yahoo.com/. If this starts happening more frequently, this test may have to change as well.

@yhirose
Copy link
Owner

yhirose commented Mar 6, 2025

@falbrechtskirchinger thanks for the report, and excellent job!

@yhirose yhirose merged commit ee0bee3 into yhirose:master Mar 6, 2025
3 of 7 checks passed
@falbrechtskirchinger falbrechtskirchinger deleted the fix-httpwatch-tests branch March 6, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants