Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes and updates the LaTeX build process, simplifies top-level Makefile targets, and refreshes documentation accordingly.
- Refactor
讲义/Makefileto embedlatexmkrules and remove the sharedlatexmk.mkinclude - Delete the now-redundant
latexmk.mkfile - Simplify root
Makefileto only build the main lecture folder and clean outputs - Update
README.mdwith streamlined build instructions and Docker usage
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| 讲义/Makefile | Added local LATEXMK flags, consolidated build/clean targets, removed include |
| latexmk.mk | Removed file; build logic is now in the subdirectory Makefile |
| README.md | Simplified manual build steps, adjusted Docker volume and environment flags |
| Makefile | Pruned unused targets (ans, gh-actions), kept only all and clean |
Comments suppressed due to low confidence (1)
README.md:37
- [nitpick] For readability and consistency with Docker CLI conventions, add spaces between flags and their arguments (e.g.,
-v "$PWD":/app,-e TERM=xterm).
docker run -v"$PWD":/app -w/app -eTERM=xterm --rm texlive/texlive:TL2023-historic make
yhwu-is
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.