Fix pack chart labels using xfun::js() for JavaScript callbacks#12
Merged
Fix pack chart labels using xfun::js() for JavaScript callbacks#12
xfun::js() for JavaScript callbacks#12Conversation
Agent-Logs-Url: https://github.com/yihui/gglite/sessions/6a675be8-1024-4063-84ca-afeb38ccbaa6 Co-authored-by: yihui-bot <264330240+yihui-bot@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
yihui-bot
March 31, 2026 18:01
View session
yihui-bot
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
G2's pack mark transforms tree data into d3-hierarchy nodes, nesting original fields under
d.data.name— inaccessible via plain JSON field strings. The fix usesxfun::js(), whichxfun::tojson()serializes as a raw JS expression (unquoted), enabling callback functions in the G2 spec.examples/marks.Rmd: Replace brokenlabels = list(list(text = 'value'))withstyle.labelTextJS callback per G2 official docs; addcolor = 'depth'encoding for visual depth cuesxfun::js()is the general pattern for any G2 property requiring a JS function (dynamic styles, tooltip titles, conditional visibility, etc.).