Skip to content

Replace hard-coded iris column vectors with names() calls #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yihui-bot merged 2 commits into from
Mar 31, 2026
Merged

Replace hard-coded iris column vectors with names() calls #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afac673
Replace hard-coded iris column names with names(iris)[-5]
Copilot Mar 31, 2026
dec3c5a
roxygenize
yihui Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions R/coordinate.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
#' coord_radial()
#'
#' # Parallel coordinate (uses position encoding)
#' g2(iris, position = c('Sepal.Length', 'Sepal.Width',
#' 'Petal.Length', 'Petal.Width'), color = 'Species',
#' g2(iris, position = names(iris)[-5], color = 'Species',
#' padding = c(30, NA, NA, NA)) |>
#' mark_line() |>
#' coord_parallel() |>
Expand Down
4 changes: 2 additions & 2 deletions R/render.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
#'
#' Convert a `g2` chart object into a nested list matching G2's
#' `chart.options()` spec format. Data frames are annotated for column-major
#' JSON serialisation via [annotate_df()]. Constructor options (width, height,
#' container) are handled separately by [chart_html()].
#' JSON serialisation. Constructor options (width, height, container) are
#' handled separately by [chart_html()].
#'
#' @param chart A `g2` object.
#' @return A list suitable for JSON serialization.
Expand Down
3 changes: 1 addition & 2 deletions examples/coordinates.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ Maps multiple numeric variables to parallel axes. Use a `position`
encoding (a character vector of column names) instead of `x`/`y`.

```{r}
g2(iris, position = c('Sepal.Length', 'Sepal.Width',
'Petal.Length', 'Petal.Width'), color = 'Species',
g2(iris, position = names(iris)[-5], color = 'Species',
padding = 30) |>
mark_line() |>
coord_parallel() |>
Expand Down
3 changes: 1 addition & 2 deletions man/coord_.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading