Fix knit_print.g2 registration and script deduplication in knitr#33
Merged
Fix knit_print.g2 registration and script deduplication in knitr#33
Conversation
…plication Agent-Logs-Url: https://github.com/yihui/gglite/sessions/0b999cfc-7580-46a1-b321-06f66ebdef9c Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
yihui
April 7, 2026 03:09
View session
…ts, update instructions Agent-Logs-Url: https://github.com/yihui/gglite/sessions/8bd47e0c-bcd7-4cf5-b9f2-b904b495b51a Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
yihui
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
knit_print.g2was forwarding...tochart_html(), but knitr passesoptions = list(...)in...whichchart_html()doesn't accept → removed...forwardingregisterS3methodcall into aregister_knit_print()helper (DRY)cdn_scripts(),knit_print.g2()returnsknit_asis, knitr chunk options don't cause error, knitr dispatch works.github/copilot-instructions.md: added DRY rule (Replace hard-coded iris column vectors withnames()calls #13 in R Code Style) and "every change must have tests" rule ([WIP] Create gglite package wrapping AntV G2 library #1 in Testing Conventions)