Conversation
…es, normalize-notebook CDN version strip Agent-Logs-Url: https://github.com/yihui/gglite/sessions/c68b6afd-7b45-4861-b8f1-4e19ce5ab854 Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
revert all changes for label() and transform_(); i'll reconsider the renaming later
the style_view() function was too narrowly scoped! it's meaningless to have a function only to change the fill! make it more general purpose; users should be able to style any aspect of the view
actually on second thought, is such a function necessary at all? if we can use a theme function to define these styles, let's just do them in the theme function instead
pls follow copilot instructions to wait for CI to be green! you committed broken code last time in an example Rmd that should have been easily caught by CI
tests/normalize-notebook.py
Outdated
|
|
||
| def strip_cdn_versions(s: str) -> str: | ||
| """Remove version specifiers (e.g. @5, @v0.14.34) from CDN URLs.""" | ||
| return re.sub(r'(@v?\d+(?:\.\d+)*)', '', s) |
There was a problem hiding this comment.
such a short regex is likely to find false positives!! you shall limit the scope, e.g.(src|href)="https://.../@
R/render.R
Outdated
| if (is.null(theme$view)) theme$view = list() | ||
| if (is.null(theme$view$viewFill)) theme$view$viewFill = '#141414' |
There was a problem hiding this comment.
come on, just do that in one step!
| if (is.null(theme$view)) theme$view = list() | |
| if (is.null(theme$view$viewFill)) theme$view$viewFill = '#141414' | |
| theme = modifyList(list(view = list(viewFill = '#141414')), theme) |
…pe, simplify dark theme, add theme explanation Agent-Logs-Url: https://github.com/yihui/gglite/sessions/c79516aa-5d29-4243-b811-a7969afeadaf Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
label()→labels.g2andtransform_()→transform.g2changes (restore original names)style_view()— styling can be done throughtheme_()...argsnormalize-notebook.pyregex to scope tosrc=/href=attributes onlyR/render.Rdark theme to use singlemodifyListcall (per reviewer suggestion)examples/marks.Rmdparse error (missing) |>beforelabel(...))examples/themes.Rmd