Skip to content

fix(model): generate string types for decimal and money columns#563

Open
taobig wants to merge 3 commits into
yiisoft:masterfrom
taobig:fix-model-decimal-property-type
Open

fix(model): generate string types for decimal and money columns#563
taobig wants to merge 3 commits into
yiisoft:masterfrom
taobig:fix-model-decimal-property-type

Conversation

@taobig

@taobig taobig commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #549

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.60%. Comparing base (ca976b0) to head (ccd08e1).

Files with missing lines Patch % Lines
src/generators/model/Generator.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #563      +/-   ##
============================================
+ Coverage     46.48%   46.60%   +0.12%     
  Complexity      586      586              
============================================
  Files            45       45              
  Lines          2519     2521       +2     
============================================
+ Hits           1171     1175       +4     
+ Misses         1348     1346       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@taobig taobig force-pushed the fix-model-decimal-property-type branch from 73927c7 to 675e556 Compare June 11, 2026 04:07
@taobig taobig force-pushed the fix-model-decimal-property-type branch from 675e556 to ccd08e1 Compare June 11, 2026 04:14
@taobig

taobig commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@samdark This CI failure(Static analysis) was not introduced by this change; please review my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant