Enhancement: Ensure messages are consumed at least once. #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is there a way to test that? |
Contributor
Author
|
use debug mode and add some code to emulate the |
The host may crashed before`rpush` was executed
noname007
changed the title
Contributor
Author
|
hi @samdark ,I need your help to review unit test code. |
samdark
reviewed
Mar 4, 2025
samdark
requested changes
Mar 5, 2025
Co-authored-by: Alexander Makarov <[email protected]>
samdark
reviewed
Mar 6, 2025
Member
samdark
left a comment
samdark
left a comment
There was a problem hiding this comment.
👍 The tests are good now. One last thing — a line for CHANGELOG.
samdark
approved these changes
Mar 6, 2025
Member
samdark
left a comment
samdark
left a comment
There was a problem hiding this comment.
👍 The tests are good now. One last thing — a line for CHANGELOG.
Member
|
Awesome. Thank you! |
Contributor
Author
|
@samdark thanks for your help |
1 similar comment
Contributor
Author
|
@samdark thanks for your help |
Member
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The host may crashed before
rpushwas executed