Fix PHPStan errors #20603
Open
Fix PHPStan errors #20603
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mspirkov
commented
Oct 13, 2025
mspirkov
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
mspirkov
commented
Oct 13, 2025
| private $_registered = false; | ||
| /** | ||
| * @var string the current working directory | ||
| * @var string|null the current working directory |
mspirkov
commented
Oct 13, 2025
| private $_errors; | ||
| /** | ||
| * @var ArrayObject list of validators | ||
| * @var ArrayObject|null list of validators |
mspirkov
commented
Oct 13, 2025
| private $_value; | ||
| /** | ||
| * @var string|int the key for the current iteration | ||
| * @var string|int|null the key for the current iteration |
mspirkov
commented
Oct 13, 2025
| * @param string $sql | ||
| * @param array $params | ||
| * @return string[]|false | ||
| * @return array[]|false |
mspirkov
commented
Oct 13, 2025
| $items[$row['name']] = $this->populateItem($row); | ||
| /** @var Role|Permission */ | ||
| $item = $this->populateItem($row); | ||
| $items[$row['name']] = $item; |
mspirkov
commented
Oct 13, 2025
|
|
||
| foreach ($this->items as $name => $item) { | ||
| /** @var Item $item */ | ||
| /** @var Role|Permission $item */ |
mspirkov
commented
Oct 13, 2025
| /** @var static */ | ||
| $result = $view->registerAssetBundle(get_called_class()); | ||
|
|
||
| return $result; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.