Skip to content

Add return value to QueryBuilder::executeResetSequence()#20765

Open
WarLikeLaux wants to merge 4 commits intoyiisoft:masterfrom
WarLikeLaux:add-executeResetSequence-return
Open

Add return value to QueryBuilder::executeResetSequence()#20765
WarLikeLaux wants to merge 4 commits intoyiisoft:masterfrom
WarLikeLaux:add-executeResetSequence-return

Conversation

@WarLikeLaux
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #20056

What does this PR do?

QueryBuilder::executeResetSequence() and its Oracle override don't return the result of execute(), so Command::executeResetSequence() always returns null. This PR adds the missing return so callers get the affected row count (int).

Continues #20056 (approved by bizley, samdark, Arhell but never merged). This PR extends the fix to oci\QueryBuilder, adds @return PHPDoc to all 3 methods, and adds a test.

Changes

  • Add missing return in QueryBuilder::executeResetSequence() and oci\QueryBuilder::executeResetSequence()
  • Add @return int PHPDoc to all 3 methods (QueryBuilder, oci\QueryBuilder, Command)

Tests

CommandTest (1 test, 2 assertions): return type check for executeResetSequence() with auto and explicit value.

@WarLikeLaux WarLikeLaux marked this pull request as ready for review March 3, 2026 17:45
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.13%. Comparing base (37b6e7b) to head (0bcc6f1).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20765   +/-   ##
=========================================
  Coverage     80.13%   80.13%           
  Complexity    11533    11533           
=========================================
  Files           374      374           
  Lines         30206    30206           
=========================================
  Hits          24207    24207           
  Misses         5999     5999           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant