Fix batchInsert() crash on array values for JSON columns#20768
Open
WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
Open
Fix batchInsert() crash on array values for JSON columns#20768WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
batchInsert() crash on array values for JSON columns#20768WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20768 +/- ##
============================================
+ Coverage 78.56% 78.58% +0.01%
- Complexity 11568 11573 +5
============================================
Files 376 377 +1
Lines 30750 30763 +13
============================================
+ Hits 24160 24174 +14
+ Misses 6590 6589 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
batchInsert()crash ("Array to string conversion") when inserting PHP arrays into JSON columns. Alternative to #20684.Problem
batchInsert()wraps arrays inJsonExpressionviadbTypecast()only when table schema is found. When schema is unavailable (table name with{{%}}notation, missing table, etc.), raw arrays pass through all type checks and hitimplode(), causing a PHP warning.Fix
JsonExpressionBuilderinyii\db- default builder for backends without a vendor-specific one (SQLite, MSSQL, Oracle, CUBRID). MySQL and PostgreSQL keep their own.QueryBuilder::defaultExpressionBuilders().is_array()fallback inbatchInsert()across 3 QueryBuilder implementations (base, pgsql, oci) - wraps raw arrays inJsonExpressionand processes viabuildExpression().Uses parameter binding (
:qp0placeholders) instead of inlinejson_encode(), which prevents SQL injection.Tests
QueryBuilderTest (2) - array value with param binding,
JsonExpressionwithQuerysubquery