Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20774 +/- ##
============================================
+ Coverage 80.13% 80.24% +0.10%
Complexity 11533 11533
============================================
Files 374 374
Lines 30206 30206
============================================
+ Hits 24207 24238 +31
+ Misses 5999 5968 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add unit tests for
AccessControlorchestration,VerbFilter, andAccessRule::matchCallback.Before / After
VerbFilter line 87 (
events()method) is covered only through behavior attachment, not directbeforeAction()calls.Escaped mutants (all equivalent)
AccessControl.php (2):
MethodCallRemoval- L104,parent::init()removal.ProtectedVisibility- L154, visibility change.VerbFilter.php (1):
ConcatOperandRemoval- L112, exception message text.AccessRule.php (11):
ProtectedVisibility×6 - L192, L201, L222, L264, L294, L303, always equivalent.ReturnRemoval×3 - L214, L257, L287,return false→ implicit null, falsy either way in boolean&&chain insideallows().UnwrapArrayMerge- L227,array_merge→ direct assign not caught becausecan()mock returns same value for all items.LogicalAnd- L249,&&→||in roleParams callable check produces same result for all tested input types (arrays, closures, callable objects).Changelog not required, because no source files changed.