Add unit tests for cache dependencies#20775
Open
WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
Open
Add unit tests for cache dependencies#20775WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
WarLikeLaux wants to merge 3 commits intoyiisoft:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20775 +/- ##
============================================
+ Coverage 80.13% 80.21% +0.07%
Complexity 11533 11533
============================================
Files 374 374
Lines 30206 30206
============================================
+ Hits 24207 24230 +23
+ Misses 5999 5976 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add unit tests for
ChainedDependency,ExpressionDependency, andDummyCache.Before / After
46 tests, 70 assertions total.
ChainedDependencyuncovered line 58:generateDependencyData()returns null. Dead code - the method is never called becauseChainedDependencyoverrides bothevaluateDependency()andisChanged(). Exists only to satisfy the abstract contract fromDependency.Changelog not required, because no source files changed.