Strengthen MSSQL QueryBuilderTest and SchemaTest coverage#20795
Open
WarLikeLaux wants to merge 4 commits intoyiisoft:masterfrom
Open
Strengthen MSSQL QueryBuilderTest and SchemaTest coverage#20795WarLikeLaux wants to merge 4 commits intoyiisoft:masterfrom
QueryBuilderTest and SchemaTest coverage#20795WarLikeLaux wants to merge 4 commits intoyiisoft:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20795 +/- ##
============================================
+ Coverage 80.13% 80.38% +0.24%
Complexity 11533 11533
============================================
Files 374 374
Lines 30206 30206
============================================
+ Hits 24207 24281 +74
+ Misses 5999 5925 -74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds tests for previously uncovered methods in MSSQL QueryBuilder, Schema and InConditionBuilder.
Coverage
mssql/QueryBuilder.phpmssql/Schema.phpNew test methods: 13 in QueryBuilderTest, 11 in SchemaTest.
Remaining uncovered: pre-2012/pre-2017 SQL Server branches, cross-catalog paths, dead code (
getAllColumnNames,isOldMssql).Changelog not required, because no source files changed.