fix: disableToolbar prop not behaving reactively #439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const foo = ref(false)When ran like this, VuetifyTiptap doesn't respect changing
foo(disableddoes)This occurs because
provide('disableToolbar', props.disableToolbar)passes the primitivetrue/falsevalue, rather than a reactive valueconst disableToolbar = inject<boolean>('disableToolbar', false)removes the default value. This is becauseundefinedwill be it's falsy replacement. Since we don't want to match types and create anotherrefwe just use undefinedI was having an issue with the dev server, so I didn't test this. It seemed like a straightforward change, sorry.