[pull] main from NVIDIA:main#354
Merged
pull[bot] merged 5 commits intoyingguo-trt:mainfrom Apr 4, 2026
Merged
Conversation
…2464) Signed-off-by: Chang Liu <9713593+chang-l@users.noreply.github.com>
Signed-off-by: TensorRT LLM <90828364+tensorrt-cicd@users.noreply.github.com>
…ron (#12150) Signed-off-by: Bo Deng <deemod@nvidia.com>
* Why? Previously, the multimodal placeholder insertion was dictated by hardcoded exception lists, which add cognitive burden when onboarding new models, and did not account for the fact that different versions of the same model architecture could have different types of chat templates that require different handling. In addition, all placeholders were either added before or after the text, instead of possibly interleaved. * What? This commit addresses the above gaps by mimicking what is done in vLLM. To that end, it: 1. introduces content format detection based on Jinja AST inspection of the chat template. 2. preserves the interleaved positions of text and media items during message parsing. 3. dispatches to the appropriate logic based on the (possibly auto-detected) content format before applying the chat template: either the template handles multimodal content natively (OpenAI-style dicts), or expects plain strings with placeholders pre-inserted. 4. inserts the multimodal placeholders. Models can also explicitly declare their `content_format` during registration if they are only meant to support one. Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Signed-off-by: TensorRT LLM <90828364+tensorrt-cicd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )