Skip to content

Use Refract - #948

Merged
joeldrapper merged 2 commits into
mainfrom
refract
Jul 21, 2025
Merged

Use Refract#948
joeldrapper merged 2 commits into
mainfrom
refract

Conversation

@joeldrapper

Copy link
Copy Markdown
Collaborator

No description provided.

@willcosgrove willcosgrove left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread lib/phlex/compiler.rb
module Phlex::Compiler
Error = Class.new(StandardError)

class BufferPush

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a vestige of a previous attempt?

@fractaledmind fractaledmind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion

Comment thread lib/phlex/compiler/method_compiler.rb Outdated
Comment on lines +25 to +29
if result
unless Refract::StatementsNode === result
clear_buffer
end
end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if result
unless Refract::StatementsNode === result
clear_buffer
end
end
clear_buffer unless result.nil? || Refract::StatementsNode === result

@joeldrapper
joeldrapper merged commit bdd4a34 into main Jul 21, 2025
13 checks passed
@joeldrapper
joeldrapper deleted the refract branch July 21, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants