Require 'date' so attribute serialization works without Rails - #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #974
If you use Phlex outside of Rails, rendering attributes can blow up with
NameError: uninitialized constant Phlex::SGML::Attributes::Date. The attribute serializer has acase/when Datebranch, butDatelives in the stdlib and isn't loaded automatically. Rails apps don't hit this because ActiveSupport pulls indateearly.I added
require "date"tolib/phlex.rb, next to the existingrequire "set". Same convention:Setis also used insideattributes.rband required at the top level.The regression test in
quickdraw/load.test.rbruns in a subprocess on purpose. Nokogiri is in the test bundle and ends up loadingdate, so checking inline would always pass and wouldn't actually catch this bug coming back.