Fixed type bug in function and removed check that prevents the purchase event of firering #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed check that prevents firering the purchase event on the Success page. When using serverSideTracking, we still want to fire the purchase event on the frontend, Google will handle double orders and, more important, we need the purchase event in GTM!
$eventName is not always a string. Remove this required type casting
Collaborator
|
I think the PHP type check is actually good enough for keeping. Instead of removing type safety, the type check actually should force calling code to pass strings. This is currently fixed here: c158682 and I don't see where else this might be an easy. As for the removal of the configuration check: This seems to be a specific issue in some environment? What is the value of I'm closing this ticket as of yet, because the first issue is supposedly fixed. Let me know if it is not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.